On 12/11/13 at 07:32pm, Borislav Petkov wrote:
> On Mon, Dec 09, 2013 at 05:42:20PM +0800, Dave Young wrote:
> > Export fw_vendor, runtime and config table physical addresses to
> > /sys/firmware/efi/fw_vendor, /sys/firmware/efi/runtime and
> > /sys/firmware/efi/config_table because kexec kernel will need them.
>
> you might wanna shorten:
>
> ... sys/firmware/efi/{fw_vendor,runtime,config_table} ...
Ok, will do.
>
> >
> > From EFI spec these 3 variables will be updated to
> > virtual address after entering virtual mode. But
> > kernel startup code will need the physical address.
> >
> > changelog:
> > Greg: add standalone sysfs files instead of add lines to systab
> > Document them as testing ABI
> > Greg: use group attrs and is_visible
> > Boris: align comments lines
> > Boris: add macros for _show functions
> > Matt: Documentation fixes.
> >
> > Signed-off-by: Dave Young <dyoung at redhat.com>
> > ---
> > Documentation/ABI/testing/sysfs-firmware-efi | 24 +++++++++++++++++
> > arch/x86/platform/efi/efi.c | 4 +++
> > drivers/firmware/efi/efi.c | 39 ++++++++++++++++++++++++++++
> > include/linux/efi.h | 3 +++
> > 4 files changed, 70 insertions(+)
> > create mode 100644 Documentation/ABI/testing/sysfs-firmware-efi
> >
> > diff --git a/Documentation/ABI/testing/sysfs-firmware-efi b/Documentation/ABI/testing/sysfs-firmware-efi
> > new file mode 100644
> > index 0000000..8c6e460
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-firmware-efi
> > @@ -0,0 +1,24 @@
> > +What: /sys/firmware/efi/fw_vendor
> > +Date: December 2013
> > +Contact: Dave Young <dyoung at redhat.com>
> > +Description:
> > + It shows the physical address of firmware vendor field in the
>
> Why doesn't this start at the same line as "Description:"?
It can, just in 1st version I copied the format from some template, I have
found it's better so updated the Users line but missed the Description.
Will do in next version.
>
> > + EFI system table.
> > +
>
> Superfluous newline.
Will remove it.
[snip]
> > +
> > static struct attribute *efi_subsys_attrs[] = {
> > &efi_attr_systab.attr,
> > + &efi_attr_fw_vendor.attr,
> > + &efi_attr_runtime.attr,
> > + &efi_attr_config_table.attr,
> > NULL, /* maybe more in the future? */
> ^^^^^
>
> Now that there's more, you can drop that wise guy comment :)
Ok.
--
Thanks for review
Dave
