On Thu, Nov 28, 2013 at 07:35:14PM +0800, Baoquan He wrote: [..] > > +void *bzImage64_load(struct kimage *image, char *kernel, > > + unsigned long kernel_len, > > + char *initrd, unsigned long initrd_len, > > + char *cmdline, unsigned long cmdline_len) > > +{ > > + > > + struct setup_header *header; > > + int setup_sects, kern16_size_needed, kern16_size, ret = 0; > > + unsigned long setup_size, setup_header_size; > > + struct boot_params *params; > > + unsigned long bootparam_load_addr, kernel_load_addr, initrd_load_addr; > > + unsigned long kernel_bufsz, kernel_memsz, kernel_align; > > + char *kernel_buf; > > + struct bzimage64_data *ldata; > > + > > + header = (struct setup_header *)(kernel + 0x1F1); > > + setup_sects = header->setup_sects; > > + if (setup_sects == 0) > > + setup_sects = 4; > > + > > + kern16_size = (setup_sects + 1) * 512; > > + if (kernel_len < kern16_size) { > > + pr_debug("bzImage truncated\n"); > > + return ERR_PTR(-ENOEXEC); > > + } > > + > > + if (cmdline_len > header->cmdline_size) { > > + pr_debug("Kernel command line too long\n"); > > + return ERR_PTR(-EINVAL); > > + } > > + > > + /* Allocate loader specific data */ > > + ldata = kzalloc(sizeof(struct bzimage64_data), GFP_KERNEL); > > + if (!ldata) > > + return ERR_PTR(-ENOMEM); > > + > > + /* Argument/parameter segment */ > > + kern16_size_needed = kern16_size; > > + if (kern16_size_needed < 4096) > > + kern16_size_needed = 4096; > > + > > + setup_size = kern16_size_needed + cmdline_len; > > + params = kzalloc(setup_size, GFP_KERNEL); > > + if (!params) { > > + ret = -ENOMEM; > > + goto out_free_loader_data; > > + } > > + > > + /* Copy setup header onto bootparams. */ > > + setup_header_size = 0x0202 + kernel[0x0201] - 0x1F1; > > + > > + /* Is there a limit on setup header size? */ > > + memcpy(¶ms->hdr, (kernel + 0x1F1), setup_header_size); > > + ret = kexec_add_buffer(image, (char *)params, setup_size, > > + setup_size, 16, 0x3000, -1, 1, &bootparam_load_addr); > > + if (ret) > > + goto out_free_params; > > + pr_debug("Loaded boot_param and command line at 0x%lx\n", > > + bootparam_load_addr); > > + > > + /* Load kernel */ > > + kernel_buf = kernel + kern16_size; > > + kernel_bufsz = kernel_len - kern16_size; > > + kernel_memsz = ALIGN(header->init_size, 4096); > > + kernel_align = header->kernel_alignment; > > + > > + ret = kexec_add_buffer(image, kernel_buf, > > + kernel_bufsz, kernel_memsz, kernel_align, 0x100000, > > + -1, 1, &kernel_load_addr); > > + if (ret) > > + goto out_free_params; > > + > > + pr_debug("Loaded 64bit kernel at 0x%lx sz = 0x%lx\n", kernel_load_addr, > > + kernel_memsz); > > + > > + /* Load initrd high */ > > + if (initrd) { > > + ret = kexec_add_buffer(image, initrd, initrd_len, initrd_len, > > + 4096, 0x10000000, ULONG_MAX, 1, &initrd_load_addr); > > Here the minimal starting addr to locate initrd is 256M, though it's > allocated from top to down, I am still wondering why. Hi Bao, Good catch. It is vestige of some hard coding I had done initially to test my patches. Forgot to remove the hardcoding here. Will fix it in next version. Thanks Vivek