Disable cyclic mode for every Xen crash dump not only when -X option is used. This way makedumpfile is much more flexible and different modes could be used to dump whole system memory (e.g. zero pages could be striped without requiring -X option). Signed-off-by: Daniel Kiper <daniel.kiper at oracle.com> --- makedumpfile.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/makedumpfile.c b/makedumpfile.c index 55e53b7..5a378d1 100644 --- a/makedumpfile.c +++ b/makedumpfile.c @@ -2928,20 +2928,20 @@ initial(void) } #endif - if (info->flag_exclude_xen_dom) { + if (is_xen_memory()) { if(info->flag_cyclic) { info->flag_cyclic = FALSE; MSG("Switched running mode from cyclic to non-cyclic,\n"); MSG("because the cyclic mode doesn't support Xen.\n"); } + } - if (!is_xen_memory()) { - MSG("'-X' option is disable,"); - MSG("because %s is not Xen's memory core image.\n", info->name_memory); - MSG("Commandline parameter is invalid.\n"); - MSG("Try `makedumpfile --help' for more information.\n"); - return FALSE; - } + if (info->flag_exclude_xen_dom && !is_xen_memory()) { + MSG("'-X' option is disable,"); + MSG("because %s is not Xen's memory core image.\n", info->name_memory); + MSG("Commandline parameter is invalid.\n"); + MSG("Try `makedumpfile --help' for more information.\n"); + return FALSE; } if (info->flag_refiltering) { -- 1.7.10.4