[Xen-devel] [PATCH 4/8] kexec: add infrastructure for handling kexec images

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/04/13 08:44, Jan Beulich wrote:
>>>> On 08.04.13 at 20:59, David Vrabel <david.vrabel at citrix.com> wrote:
>> +        ret = kimage_add_page(image, page_to_mfn(page) << PAGE_SHIFT);
> 
> Constructs like this aren't portable. You ought to use
> page_to_maddr(), and have the called function have paddr_t
> instead of unsigned long as the respective parameter.

I will make this change but it isn't clear to me why this isn't portable.

David



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux