Simon, Zhang, Am 01.04.2013 07:16, schrieb Zhang Yanfei: >> I believe the above portion will break make dist my >> causing it to omit purgatory/arch/* other than >> purgatory/arch/$(ARCH) > > Ah, I've missed this in my review, too. > > Other than this, the change about purgatory/sha256.o below looks sound, > right? The dist mechanism is quite strange and error prone. Why can't you just use git archive in the $(TARBALL) target? I'll happily send a patch... Back to the purgatory/sha256.o issue, I did some more tests. First I thought memcpy() within purgatory is slow, but it isn't. Does kexec reset the CPU so some kind of legacy mode during purgatory? It looks like the same code in sha256.o is fast in normal user space but very slow during purgatory. Computing sha256 of a 9MiB blob takes less than a second in user space and 16 seconds (with my patch). Otherwise it takes > 25 seconds. Thanks, //richard
