From: Atsushi Kumagai <kumagai-atsushi@xxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 01/16] [PATCH v3 1/12] Introduce cyclic mode to keep memory usage constant.
Date: Tue, 4 Sep 2012 11:45:23 +0900
> Hello HATAYAMA-san,
>
> On Mon, 03 Sep 2012 12:16:37 +0900 (JST)
> HATAYAMA Daisuke <d.hatayama at jp.fujitsu.com> wrote:
>
>> From: HATAYAMA Daisuke <d.hatayama at jp.fujitsu.com>
>> Subject: Re: [PATCH 01/16] [PATCH v3 1/12] Introduce cyclic mode to keep memory usage constant.
>> Date: Mon, 3 Sep 2012 11:50:57 +0900
>>
>> > From: Atsushi Kumagai <kumagai-atsushi at mxc.nes.nec.co.jp>
>> > Subject: [PATCH 01/16] [PATCH v3 1/12] Introduce cyclic mode to keep memory usage constant.
>> > Date: Thu, 30 Aug 2012 16:45:21 +0900
>> >
>> > <cut>
>> >
>> >> diff --git a/makedumpfile.c b/makedumpfile.c
>> >> index d024e95..21bb55a 100644
>> >> --- a/makedumpfile.c
>> >> +++ b/makedumpfile.c
>> >> @@ -2553,6 +2553,8 @@ initial(void)
>> >> info->name_memory);
>> >> return FALSE;
>> >> }
>> >> + info->flag_cyclic = FALSE;
>> >> +
>> >
>> > Please disable cyclic mode on sadump dumpfiles, too.
>
> I will take care of sadump (and Xen) in the same way as for refiltering.
>
Thanks.
>> Also, there's no information to users about disabling cyclic mode.
>> Now switching from cyclic to normal mode is implicitly done. This is
>> confusing. I think some message indicating that, is necessary.
>
> As you said, it is unkind that no message is displayed.
> I will show message as below when running mode is switched.
>
> MSG("Switched running mode from cyclic to non-cyclic,\n");
> MSG("because cyclic mode doesn't support sadump format.\n");
>
For refiltering case, too, just in case.
>
> BTW, cyclic mode doesn't support the three below now.
>
> - Xen
> - refiltering
> - sadump
>
> I will support Xen after Xen4 patch-set is merged.
>
> On the other hand, I think the bottom two will be used in the 1st kernel
> and makedumpfile can allocate enough memory, so cyclic mode isn't necessary
> for them.
> Therefore, I won't support them now. What do you think ?
>
Yes, I think so, too.
Thanks.
HATAYAMA, Daisuke
