Hi Atsushi, Thanks for reviewing. I will work on your comments. On 2012-10-29 13:36, Atsushi Kumagai wrote: > Hello Aravinda, > > Now, I have reviewed your patches to [PATCH 4/7], > so please give me a little more time. > sure... > BTW, do you have any test case for this feature ? > If you can give it to me, it's very helpful. > I have developed few semi-automated tests. I will automate it completely and mail it to you in 2-3 days. > > Thanks > Atsushi Kumagai > > > On Wed, 06 Jun 2012 15:34:23 +0530 > Aravinda Prasad <aravinda at linux.vnet.ibm.com> wrote: > >> makedumpfile security key filtering enhancement - Add Eppic language >> support (formerly known as SIAL) to specify rules to scrub data in a >> dumpfile. Eppic was previously part of crash source code repository. >> >> The following series of patches enhance the makedumpfile to provide >> a more powerful way to specify rules and commands to traverse and >> erase complex data structures in a dump file by integrating Embeddable >> Pre-Processor and Interpreter for C (eppic). >> >> Eppic is an interpreter that facilitates access to the symbol and type >> information stored in an executable image or a dump file. Eppic defines >> a language semantic which is similar to C. Eppic macros can be used to >> specify rules/commands to erase data in an image file. makedumpfile >> will interpret the rules/commands provided by eppic macros with the >> help of eppic library and will suitably erase the required data in a >> dump file. Eppic provides a lot of language constructs like conditional >> statements, logical and arithmetic operators, nested loops, functions, >> etc., to traverse nested lists and trees and conditionally erase data >> in the dump file, enabling users to literally erase any data in the >> dump file which is accessible through global symbols. >> >> The series of patches integrates eppic with makdumpfile. These patches >> require eppic library libeppic.a and eppic_api.h header file. The >> libeppic.a library can be built from the eppic source code available >> at the following URL: >> >> http://code.google.com/p/eppic/ >> >> TODO: >> >> - Currently, works only for symbols in vmlinux, extend it to module >> symbols >> - Functionality support: >> - Implement the following callback functions. >> - apialignment >> - apigetenum >> - apigetdefs >> - Other functionalities specified in the code with TODO tag >> - Support specifying eppic macros in makedumpfile.conf file >> - Update erase info >> >> --- >> >> Aravinda Prasad (7): >> Initialize and setup eppic >> makedumpfile and eppic interface layer >> Eppic call back functions to query a dump image >> Implement apigetctype call back function >> Implement apimember and apigetrtype call back functions >> Extend eppic built-in functions to include memset function >> Support fully typed symbol access mode >> >> >> Makefile | 6 - >> dwarf_info.c | 338 ++++++++++++++++++++++++++++++++++++++++ >> dwarf_info.h | 18 ++ >> erase_info.c | 72 ++++++++- >> erase_info.h | 3 >> extension_eppic.c | 446 +++++++++++++++++++++++++++++++++++++++++++++++++++++ >> extension_eppic.h | 78 +++++++++ >> makedumpfile.c | 7 + >> makedumpfile.h | 6 + >> 9 files changed, 967 insertions(+), 7 deletions(-) >> create mode 100644 extension_eppic.c >> create mode 100644 extension_eppic.h >> >> -- >> Aravinda Prasad >> > -- Regards, Aravinda
