[PATCH] makedumpfile: fix to exclude_unnecessary_pages_cyclic

[kumagai-atsushi@xxxxxxxxxxxxxxxxx (Atsushi Kumagai)]

Hello Cliff,

On Wed, 21 Nov 2012 13:45:51 -0600
Cliff Wickman <cpw at sgi.com> wrote:

> 
> The || in exclude_unnecessary_pages_cyclic() makes makedumpfile
> scan all the memmap sections, not just the ones containing the current
> cyclic range.
> 
> Diffed against makedumpfile-1.5.1

Thanks, I'll merge this patch into v1.5.1.


Atsushi Kumagai

> ---
>  makedumpfile.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: makedumpfile-1.5.1/makedumpfile.c
> ===================================================================
> --- makedumpfile-1.5.1.orig/makedumpfile.c
> +++ makedumpfile-1.5.1/makedumpfile.c
> @@ -4187,7 +4187,7 @@ exclude_unnecessary_pages_cyclic(void)
>  			if (mmd->mem_map == NOT_MEMMAP_ADDR)
>  				continue;
>  
> -			if (mmd->pfn_end >= info->cyclic_start_pfn || mmd->pfn_start <= info->cyclic_end_pfn) {
> +			if (mmd->pfn_end >= info->cyclic_start_pfn && mmd->pfn_start <= info->cyclic_end_pfn) {
>  				if (!__exclude_unnecessary_pages(mmd->mem_map,
>  								 mmd->pfn_start, mmd->pfn_end))
>  					return FALSE;