Hello Petr,
I'm sorry for having kept you waiting.
I have a small comment for this patch.
On Fri, 24 Aug 2012 17:43:23 +0200
Petr Tesarik <ptesarik at suse.cz> wrote:
> In Xen-4.0+, usage of a page must be determined from its PGC_xxx
> flags, which are stored in the highest bits of the _count field
> of struct page_info.
>
> Let's keep the original function for Xen3 only and add a new
> function for walking the pages under Xen4. This avoids adding many
> new conditionals to the inner loop and also makes the logic easier
> to follow for all Xen versions.
>
> Signed-off-by: Norbert Trapp <norbert.trapp at ts.fujitsu.com>
> Signed-off-by: Petr Tesarik <ptesarik at suse.cz>
>
> ---
> makedumpfile.c | 102
> +++++++++++++++++++++++++++++++++++++++++++++++++++++----
> makedumpfile.h | 25 +++++++++++++
> 2 files changed, 121 insertions(+), 6 deletions(-)
>
> --- a/makedumpfile.h
> +++ b/makedumpfile.h
> @@ -78,6 +78,31 @@ int get_mem_type(void);
> #define LSEEKED_PDATA (3)
>
> /*
> + * Xen page flags
> + */
> +#define BITS_PER_BYTE (8)
> +#define BITS_PER_LONG (BITS_PER_BYTE * sizeof(long))
BITPERBYTE is already defined as meaning the same as BITS_PER_BYTE,
so I will change this patch to use BITPERBYTE instead of BITS_PER_BYTE
when merging.
makedumpfile.h:
164
165 #define BITPERBYTE (8)
166 #define PGMM_CACHED (512)
Thanks
Atsushi Kumagai
