On Thu, 08 Mar 2012 at 17:29 GMT, Maxim Kammerer <mk at dee.su> wrote: > Hi, > > In kexec/arch/i386/x86-linux-setup.c:setup_linux_vesafb(): > > fprintf(stderr, "%s: %dx%dx%d @ %lx +%x\n", __FUNCTION__, > var.xres, var.yres, var.bits_per_pixel, > fix.smem_start, fix.smem_len); > > This message is pretty annoying (especially if kexec is loaded several > times with different parameters during startup/shutdown). Looking in > that source file, that's the only fprintf which is not an error. Is it > really necessary? > This should be just a debugging message, and should not be printed unless debugging is enabled, so s/fprintf/dbgprintf/...