On Mon, Jul 23, 2012 at 10:35:12AM -0400, Vivek Goyal wrote: > On Wed, Jul 18, 2012 at 09:33:51AM -0400, Vivek Goyal wrote: > > [..] > > > > + char temp_buf[1024]; > > > > + bool last_line = false; > > > > > > Is there a chance of over-running temp_buf? > > > > > > I would be more comfortable if there was a check below to > > > ensure that len can never be greater than sizeof(temp_buf). > > > > Hi Simon, > > > > Agreed. Making sure temp_buf does not overflow is a good idea. Here is > > the udpated patch. > > > > Hi Simon, > > Do you have any more concerns with this patch. If not, can you please > apply it. Sorry, I missed the updated patch somehow. I'll apply it ASAP.
