Hi Aruna, On Wed, 1 Feb 2012 13:15:18 +0900 Atsushi Kumagai <kumagai-atsushi at mxc.nes.nec.co.jp> wrote: > Hi Aruna, > > On Tue, 31 Jan 2012 15:56:33 +0530 > Aruna Balakrishnaiah <aruna at linux.vnet.ibm.com> wrote: > > > > > The patch fixes the segmentation fault issue of makedumpfile when a > > user specifies an invalid file name with -x/--split option. > > The patch takes care of such a scenario by setting .find_debuginfo to > > a function pointer which returns -1 and throws error messages against > > invalid vmlinux file input. With a valid vmlinux file .find_debuginfo > > was never invoked since the absolute path of debuginfo was known by the > > time we call init_dwarf_info. > > > > Signed-off-by: Aruna Balakrishnaiah <aruna at linux.vnet.ibm.com> > > --- > > dwarf_info.c | 25 +++++++++++++++++++++++++ > > 1 files changed, 25 insertions(+), 0 deletions(-) I'm reviewing your patch and it looks good. However, I can't guess that the segmentation fault caused by --split option because --split option doesn't require an argument. Would you tell me the case that you thought. Thanks Atsushi Kumagai
