Hello, Andrew. 2012/12/7 Andrew Morton <akpm at linux-foundation.org>: > On Fri, 7 Dec 2012 01:09:27 +0900 > Joonsoo Kim <js1304 at gmail.com> wrote: > >> This patchset remove vm_struct list management after initializing vmalloc. >> Adding and removing an entry to vmlist is linear time complexity, so >> it is inefficient. If we maintain this list, overall time complexity of >> adding and removing area to vmalloc space is O(N), although we use >> rbtree for finding vacant place and it's time complexity is just O(logN). >> >> And vmlist and vmlist_lock is used many places of outside of vmalloc.c. >> It is preferable that we hide this raw data structure and provide >> well-defined function for supporting them, because it makes that they >> cannot mistake when manipulating theses structure and it makes us easily >> maintain vmalloc layer. >> >> I'm not sure that "7/8: makes vmlist only for kexec" is fine. >> Because it is related to userspace program. >> As far as I know, makedumpfile use kexec's output information and it only >> need first address of vmalloc layer. So my implementation reflect this >> fact, but I'm not sure. And now, I don't fully test this patchset. >> Basic operation work well, but I don't test kexec. So I send this >> patchset with 'RFC'. >> >> Please let me know what I am missing. >> >> This series based on v3.7-rc7 and on top of submitted patchset for ARM. >> 'introduce static_vm for ARM-specific static mapped area' >> https://lkml.org/lkml/2012/11/27/356 >> But, running properly on x86 without ARM patchset. > > This all looks rather nice, but not mergeable into anything at this > stage in the release cycle. > > What are the implications of "on top of submitted patchset for ARM"? > Does it depens on the ARM patches in any way, or it it independently > mergeable and testable? > Yes. It depends on ARM patches. There is a code to manipulate a vmlist in ARM. So without applying ARM patches, this patchset makes compile error for ARM. But, build for x86 works fine with this patchset :) In ARM patches, a method used for removing vmlist related code is same as 1/8 of this patchset. But, it includes some optimization for ARM, so I sent it separately. If it can't be accepted, I can rework ARM patches like as 1/8 of this patchset.
