On Tue, Apr 17, 2012 at 09:52:42AM +0800, zhangyanfei wrote: > ? 2012?04?13? 07:00, Greg KH ??: > > On Wed, Apr 11, 2012 at 09:57:34AM +0800, zhangyanfei wrote: > >> This patch creates sysfs file to export where VMCSINFO is allocated, > >> as below: > >> $ cat /sys/kernel/vmcsinfo > >> 1cb88a0 2000 > >> number on the left-hand side is the physical address of VMCSINFO, > >> while the one on the right-hand side is the max size of VMCSINFO. > > > > Ick, why do you have 2 values in one sysfs file, that's not nice, or > > good. > > > > What's wrong with 2 different files? > > > > The reason why I put the 2 values in one sysfs file is that there is a similar > file 'vmcoreinfo' in sysfs. > # cat /sys/kernel/vmcoreinfo > 1d75380 1000 Then that should be fixed as well, using two different file names now :( thanks, greg k-h
