On Mon, Sep 19, 2011 at 07:11:59AM -0700, Lei Wen wrote: > Thanks for this reminding! > Then how about add flush_icache_range at the end of machine_kexec_prepare? > Could it be acceptable? I think it should be done. > Also with this change, do we still need flush icache at the end stage of > machine_kexec? You need to use flush_icache_range() whenever you write _instructions_ to an area of memory which you intend to execute. If you're not writing instructions, you shouldn't use flush_icache_range().