On Tue, Nov 08, 2011 at 04:22:08PM +0900, Simon Horman wrote: > On Tue, Nov 08, 2011 at 01:26:23PM +0800, Dave Young wrote: > > hole_align == 0 check is not neccesary, because it will be set to > > pagesize if it's zero. Just remove it here. > > > > Hi Dave, > > it looks like the if condition can never be true due > to hole_base being set to a non-zero value on the > previous line. > > Which is a long way of saying, I like your patch. Hi Dave, I have applied your patch to my kexec-tools tree on github.