Hi Michael, Thank you for the explanation. On Fri, 18 Mar 2011 11:11:37 +0100 Michael Holzheu <holzheu at linux.vnet.ibm.com> wrote: > > On Thu, 2011-03-17 at 15:39 +0900, Ken'ichi Ohmichi wrote: > > Hi Mahesh, > > > > On Tue, 15 Mar 2011 22:39:23 +0530 > > Mahesh J Salgaonkar <mahesh at linux.vnet.ibm.com> wrote: > > > > > > From: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com> > > > > > > While excluding free pages from s390x dumps taken on LPAR, makedumpfile > > > fails to convert page address to pfn. The reason is, the memory for > > > mem_section structure is allocated below '_stext' and since KVBASE is > > > set to SYMBOL(_stext), the function is_kvaddr() fails and return NULL > > > address. > > > > Why do we need this patch ? > > to support the latest kernel version of s390 ? > > or to support LPAR of s390 ? > > The problem is that on s390 depending on the kernel configuration it can > happen that memory below _stext is available for buffer allocation. > Therefore the mem_section structure has been allocated below _stext. On > s390 the kernel page tables have a 1:1 mapping from 0 to memory_end > (memory holes are possible). Therefore I think the check "> 0" is ok for > s390. I see. And I confirmed there is the same code (kvbase is 0) in the crash utility in the case of s390x, so this change is right. Mahesh's patch has been merged to the git tree. http://makedumpfile.git.sourceforge.net/git/gitweb.cgi?p=makedumpfile/makedumpfile;a=commit;h=c69f915b8163bb9209cb329a6186b7261b545a4b Thanks Ken'ichi Ohmichi
