On 06/06/11 14:30, David Laight wrote: >>> Changed the add_usable_mem_property() to accept FILE* fp instead of > int fd, >>> as most of the other users of read_memory_region_limits() deals with > FILE*. >>> >>> Signed-off-by: Suzuki K. Poulose<suzuki at in.ibm.com> >> >> Could you please let me know your thoughts/comments about this patch ? > > Is the change to use 'FILE *' actually progress? > I'd have thought that the randomly aligned read/lseek system calls > that this allows to happen are not desirable for anything that > isn't a true file. I will revert the other users back to 'fd' > > I'd also suggest that the sizeof's should be applied to the > actual type of the variable being read/written, not arbitrarily > 'long' or 'int', and this probably ought to be some fixed size type. I have used 'unsigned long'(for word sized values) or 'unsigned long long' (for double words) just to make sure we get the right values. Is this OK ? Thanks Suzuki
