Hi Mahesh, On Thu, 11 Aug 2011 17:33:48 +0530 Mahesh J Salgaonkar <mahesh at linux.vnet.ibm.com> wrote: > > > > > > BTW makedumpfile.c has become a large file which is bigger than 10KLine, > > > and I will separate it to some files for the maintenance. > > > > To shrink makedumpfile.c file, I made a prototype patch. > > (commit 40f5724152047a12e4ac9db51d9f9e00e7a79ebe of filter-out-devel branch) > > And I'd like to see your opinion. > > > > I like the idea. The prototype patch looks good. I think we can > even separate out the module symbol load/clean up functions including all > associated functions out of makedumpfile.c. What do you think? Yes. I think it is a good direction that we separete out the module symbol load code, which is added by you, from makedumpfile.c. And I will try it. Thanks Ken'ichi Ohmichi