On Fri, Apr 29, 2011 at 10:59:40AM +0800, Cong Wang wrote: > ? 2011?04?29? 06:05, Simon Horman ??: > >On Thu, Apr 28, 2011 at 09:15:39AM -0400, Vivek Goyal wrote: > >>On Thu, Apr 28, 2011 at 03:57:48PM +0800, Cong Wang wrote: > >>>? 2011?04?27? 23:01, Vivek Goyal ??: > >>>>Amerigo, > >>>> > >>>>Now who will do following initialization for ppc? > >>>> > >>>>info->backup_src_start = BACKUP_SRC_START; > >>>>info->backup_sz = BACKUP_SRC_END - BACKUP_SRC_START + 1; > >>>> > >>>>I think I have concern for mips too. > >>> > >>>Right, we need to initialize them in load_crashdump_segments(). > >>> > >>>How about the attached patch? It is untested. > >>> > >> > >>>Signed-off-by: WANG Cong<amwang at redhat.com> > >> > >>Ok, this one looks better. > > > >Vivek, can I take that as an Acked-by? > > > >Cong, can you clarify if I need to revert any of your recent patches or > >not? > > No, that attached patch is right to fix the first one, so you don't > need to revert anything. Thanks, pushed.