On Thu, Sep 09, 2010 at 05:01:13PM -0400, Neil Horman wrote: > hey- > Got a segfault recently on ppc64 kexec with a system with 256Gb of ram. > Tracked it back to running over the end of the device tree buffer that we have > allocated. I can't find any docs on how big the device tree can legally be, so > for now I figure just upping its size is sufficient. Confirmed that this fixed > the segfault. > > Signed-off-by: Neil Horman <nhorman at tuxdriver.com> > > > fs2dt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > diff --git a/kexec/arch/ppc/fs2dt.c b/kexec/arch/ppc/fs2dt.c > index 238a3f2..2f0f937 100644 > --- a/kexec/arch/ppc/fs2dt.c > +++ b/kexec/arch/ppc/fs2dt.c > @@ -33,7 +33,7 @@ > > #define MAXPATH 1024 /* max path name length */ > #define NAMESPACE 16384 /* max bytes for property names */ > -#define TREEWORDS 65536 /* max 32 bit words for properties */ > +#define TREEWORDS 131070 /* max 32 bit words for properties */ > #define MEMRESERVE 256 /* max number of reserved memory blks */ > #define MAX_MEMORY_RANGES 1024 > #define COMMAND_LINE_SIZE 512 /* from kernel */ > Ben, do you have any thoughts on this? It would be nice if we could avoid just making this buffer bigger until the crashes stop :) Neil
