On Wed, May 05, 2010 at 01:35:21PM +1000, Michael Neuling wrote: > > > In message <20100505023316.GF13035 at verge.net.au> you wrote: > > On Wed, May 05, 2010 at 11:48:53AM +1000, Michael Neuling wrote: > > > 6adc05c6e3fdbc8b9f5d915af78ca05d0a09cb17 "some kexec MIPS > > > improvements" broke pp64 as it turned on -Werror for all archs. > > > > > > This fixes the warning and hence ppc64 building. > > > > Thanks. > > > > While I'm very much in favour of using -Werror for testing > > and these kind of patches are great, I think that -Werror > > by default is rather silly. We can't control what will be > > a warning in the future and sometimes fixing warnings isn't > > appropriate - for instance there are warnings in fs2dt.c at > > the moment, that is currently considered an upstream problem. > > > > In short, this patch is great. But I plan to also remove -Werror > > as the default now that its been brought to my attention. > > Cool. My second patch should do this for all but MIPS. Unfortunately the second patch breaks make tarball. For now I have committed the following:
