On Thu, Jun 24, 2010 at 09:33:56AM +0200, ext Masayuki Igawa wrote:
> Hi, Mika.
(...)
> > +unsigned long long
> > +vaddr_to_paddr_arm(unsigned long vaddr)
> > +{
> > + unsigned long long paddr;
> > +
> > + if ((paddr = vaddr_to_paddr_general(vaddr)) != NOT_PADDR)
> > + return paddr;
>
> Here is a checkpatche.pl's error.
> ====
> ERROR: do not use assignment in if condition
> #303: FILE: arm.c:189:
> + if ((paddr = vaddr_to_paddr_general(vaddr)) != NOT_PADDR)
>
> total: 1 errors, 0 warnings, 261 lines checked
> ====
Ah, didn't notice that. Thanks.
> How about is this?
> ====
> +unsigned long long
> +vaddr_to_paddr_arm(unsigned long vaddr)
> +{
> + unsigned long long paddr = vaddr_to_paddr_general(vaddr);
> +
> + if (paddr != NOT_PADDR)
> + return paddr;
> ====
Yeah, looks OK to me.
Do you want me to send a revisited version of the patches or do you change that
yourself?
> BTW, I'm testing these patches for x86/x86_64 arch now.
> I'll merge these patches after my testing.
Cool, thanks.
> But I cannot test for ARM because have no test machines of ARM.
Well I can do the testing for ARM (unless someone else, who is using ARM kdump
currently, wants to test this). If the above is the only change it should still
work.
Thanks,
MW
