, Frederic Weisbecker wrote: > On Wed, Jun 23, 2010 at 12:19:38PM +0200, Andi Kleen wrote: >> , Ian Munsie wrote: >>> From: Ian Munsie<imunsie at au1.ibm.com> >>> >>> This patch converts numerous trivial compat syscalls through the generic >>> kernel code to use the COMPAT_SYSCALL_DEFINE family of macros. >> >> Why? This just makes the code look uglier and the functions harder >> to grep for. > > > Because it makes them usable with syscall tracing. Ok that information is missing in the changelog then. Also I hope the uglification<->usefullness factor is really worth it. The patch is certainly no slouch on the uglification side. It also has maintenance costs, e.g. I doubt ctags and cscope will be able to deal with these kinds of macros, so it has a high cost for everyone using these tools. For those it would be actually better if you used separate annotation that does not confuse standard C parsers. -Andi
