On Thu, Oct 30, 2008 at 03:50:31PM +0200, Avi Kivity wrote: <snip> >> >> +static void (*virt_disable_fn)(unsigned int cpu); >> > > Since you never use the cpu argument, I suggest dropping it. It is a leftover from when I was using cpus_hardware_enabled to check if vmx was enabled, before I've noticed I could just check CR4.VMXE. I will drop it. -- Eduardo