Patch corrected. ( git_kexec_powerpc_v2.patch is attached.) I tested it on ppc64 pasemi electra board. Both kexec -l and kexec -p works. Maxim. 2008/10/15 Simon Horman <horms at verge.net.au> > On Tue, Oct 14, 2008 at 07:11:19PM +0400, Maxim Uvarov wrote: > > Hello all, > > > > As you all know it is not easy to count exact value of memory ranges from > > device tree on powerpc. > > It very depends on how dts file was written. What do you think about > really > > dynamic allocation buffers > > for this buffers? > > Conceptually I have no objections to the change, > though I would like to get some review from ppc people. > (linuxppc-dev at ozlabs.org CCed) > > > Patch is attached. > > This patch doesn't seem to compile for me. > > # powerpc64-unknown-linux-gnu-gcc --version > powerpc64-unknown-linux-gnu-gcc (GCC) 4.1.1 > Copyright (C) 2006 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. There is NO > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > > #make > [snip] > kexec/arch/ppc64/kexec-ppc64.c:100: warning: function declaration isn't a > prototype > kexec/arch/ppc64/kexec-ppc64.c: In function 'realloc_memory_ranges': > kexec/arch/ppc64/kexec-ppc64.c:107: warning: passing argument 1 of > 'realloc' makes pointer from integer without a cast > kexec/arch/ppc64/kexec-ppc64.c:107: error: too few arguments to function > 'realloc' > kexec/arch/ppc64/kexec-ppc64.c:102: warning: unused variable 'tmp' > > -- > Simon Horman > VA Linux Systems Japan K.K., Sydney, Australia Satellite Office > H: www.vergenet.net/~horms/ <http://www.vergenet.net/%7Ehorms/> > W: www.valinux.co.jp/en > > -- Best regards, Maxim Uvarov -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.infradead.org/pipermail/kexec/attachments/20081015/ac994af6/attachment.html -------------- next part -------------- A non-text attachment was scrubbed... Name: git_kexec_powerpc_v2.patch Type: text/x-patch Size: 4908 bytes Desc: not available Url : http://lists.infradead.org/pipermail/kexec/attachments/20081015/ac994af6/attachment.bin
