On Sun, Oct 12, 2008 at 03:39:55PM +0200, Sebastian Andrzej Siewior wrote: > * Simon Horman | 2008-10-08 14:03:26 [+1100]: > > >> +#ifdef WITH_GAMECUBE > >> +static int go_purgatory = 0; > >> +#else > >> +static int go_purgatory = 1; > >> +#endif > > > >Can you just use WITH_GAMECUBE inside elf_ppc_load() and remove > >the need for go_purgatory, or do you plan to make go_purgatory > >switchable at run-time at some point in the future? > For the first shot I would prefer to use WITH_GAMECUBE inside of > elf_ppc_load(). In longterm I don't see any reason why GameCube can't > use the purgatory code like the other archs and get the memory maps from > the device tree. However I'm not sure if GameCube still runs on a recent > kernel: now that arc/ppc isn't available anymore GameCube has to pass a > dtb somehow and this isn't the case. So therefore I would like the keep > #ifdef and the exisiting behavior until someone clears this up. Ok, in this case I would like to request that you remove go_purgatory (for now) and just use #ifdef WITH_GAMECUBE instead. I think that it will make things cleaner (for now). -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en
