Hi Neil, I had created similar patch, but your patch is better than mine because your patch has right configuration dependency. So I think this patch is fine. Reviewed-by: Ken'ichi Ohmichi <oomichi at mxs.nes.nec.co.jp> Thanks Ken'ichi Ohmichi * Reference: http://lists.infradead.org/pipermail/kexec/2008-June/001970.html Neil Horman wrote: > Hey- > The makdumpdile dump filtering program, in some modes of operation needs > the node_data and/or contig_page_data symbols to function properly. These > symbols are missing from the powerpc kernel. This patch adds those symbols in > properly. Tested successfully by myself and the reporter. > > Regards > Neil > > Signed-off-by: Neil Horman <nhorman at tuxdriver.com> > > > machine_kexec.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > > diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c > index aab7688..2f9b5aa 100644 > --- a/arch/powerpc/kernel/machine_kexec.c > +++ b/arch/powerpc/kernel/machine_kexec.c > @@ -44,6 +44,16 @@ void machine_kexec_cleanup(struct kimage *image) > ppc_md.machine_kexec_cleanup(image); > } > > +void arch_crash_save_vmcoreinfo(void) > +{ > +#ifdef CONFIG_NEED_MULTIPLE_NODES > + VMCOREINFO_SYMBOL(node_data); > + VMCOREINFO_LENGTH(node_data, MAX_NUMNODES); > +#else > + VMCOREINFO_SYMBOL(contig_page_data); > +#endif > +} > + > /* > * Do not allocate memory (or fail in any way) in machine_kexec(). > * We are past the point of no return, committed to rebooting now.
