On Wed, Oct 08, 2008 at 12:40:57PM +1100, Simon Horman wrote: [snip] > > --- kexec-tools-orig/kexec/arch/ppc64/crashdump-ppc64.h 2008-09-24 > > 14:46:55.000000000 +0530 > > +++ kexec-tools/kexec/arch/ppc64/crashdump-ppc64.h 2008-09-16 > > 19:18:57.000000000 +0530 > > @@ -28,4 +28,7 @@ extern uint64_t crash_size; > > extern unsigned int rtas_base; > > extern unsigned int rtas_size; > > > > +uint64_t lmb_size; > > +unsigned int num_of_lmbs; > > + > > I am a little confused about why these variables need to be global > as they only seem to be used inside get_crash_memory_ranges(). > I am also a little confused about how they are initialised. Ok, looking further I see that these are also used by code introduced in patch 2 and are initialised in code added by patch 3. It would be nicer have them intitalised in this patch as I'm not sure that the code will work sensibly with just this patch or just this patch and patch 2 applied, which may be important for bisection in the future. -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en
