On Sun, Nov 16, 2008 at 09:57:55AM +0200, Avi Kivity wrote: > Eduardo Habkost wrote: >> Hi, >> >> This is a new spin of the series to disable vmx on kdump and on >> emergency_restart. Now we avoid doing the function pointer stuff by >> moving 4 small KVM functions to a header, as inline functions. The code >> looks much simpler now, but we have to be more careful because some >> additional code will run on kdump and reboot even when KVM is never >> loaded. >> >> I haven't tested the SVM changes on AMD CPUs. The changes are really >> simple, but some testing is welcome. >> >> This series is against tip.git#master, that already contains the >> nmi_shootdown_cpus() changes I've submitted previously. >> >> >> > > Looks good. I am slightly uneasy about moving things away from vmx.h > and svm.h; can we keep them there and #include those headers directly? I see them as bits of code that are being moved from KVM to the kernel core. I think moving those bits outside arch/x86/kvm/ makes this more clear: people can expect that code living in arch/x86/kvm/ is never used if CONFIG_KVM was not set. Because of their location, I thought svm.h and vmx.h had KVM-specific code. Now I've noticed they are independent from KVM. May I move svm.h and vmx.h to arch/x86/include/asm, then? -- Eduardo
