Avi Kivity <avi at redhat.com> writes: > Eduardo Habkost wrote: >> We could move the set_virt_disable_func() calls to vmx.c and svm.c (on >> hardware_setup/hardware_unsetup). One could argue that it is sort of a >> coincidence that we need the code for both vmx and svm. >> > > I don't share this fear of function calls, but perhaps that's due to lack of > experience with kdump. Mostly I'm just afraid of extra complexity. > If you want to be extra simple and safe, remove kvm from the equation. Make the > disabling code part of kdump/emergency_restart and only rely on the convention > that cr3.vmxe == vmxon. Convention? > That has the advantage of working with other virtualization systems as well. Sounds good. Eric
