On Wed, Jun 25, 2008 at 9:03 AM, Bernhard Walle <bwalle at suse.de> wrote:
> * Yinghai Lu [2008-06-25 09:01]:
>> On Wed, Jun 25, 2008 at 5:02 AM, Bernhard Walle <bwalle at suse.de> wrote:
>> > }
>> > early_param("mem", parse_memopt);
>> > @@ -1023,6 +1025,7 @@ static int __init parse_memmap_opt(char *p)
>> > e820_add_region(start_at, mem_size, E820_RESERVED);
>> > } else {
>> > end_user_pfn = (mem_size >> PAGE_SHIFT);
>> > + e820_update_range(mem_size, ULLONG_MAX, E820_RAM, E820_RESERVED);
>> > }
>> > return *p == '\0' ? 0 : -EINVAL;
>> > }
>> > --
>>
>> only this one is needed now. but please change ULLONG_MAX to
>> ULLONG_MAX - mem_size
>
> Why can't we add that check at the beginning of e820_update_range() as
> you suggested?
that patch about fixing e820_update_rang is in tip/setup-memory.
so the one is supposed to be ok, but it is good to keep good input
parameter too.
YH
