On Mon, Jun 09, 2008 at 10:57:34PM +0200, Bernhard Walle wrote: > * Vivek Goyal <vgoyal at redhat.com> [2008-06-09 16:54]: > > > > On Mon, Jun 09, 2008 at 10:42:11PM +0200, Bernhard Walle wrote: > > > Hi Vivek, > > > > > > * Vivek Goyal <vgoyal at redhat.com> [2008-06-09 16:29]: > > > > > > > > Can you please put some more explanation comment here to explain that > > > > why it is ok to return with success, despite the fact that we never > > > > reserved any memory. > > > > > > Do you think that's ok? > > > > > > When booting the kdump kernel, the MP tables (for example, > > > or other firmware-reserved memory) of the BIOS are beyond > > > end_pfn. (kexec-tools adds exactmap parameters to the kernel > > > so that the E820 map is no longer used.) Therefore, it's ok > > > to return "success" here. For normal boot, the MP tables > > > must be reserved normally. > > > > > > > Looks good. Thanks > > Should I resend the whole patch series to Linus for inclusion? > I am really not sure. :-). In the past, Andrew picked up the patches, kept in his tree for couple of days and if something is important, he will push it out to Linus. Thanks Vivek
