On Sun, Jun 08, 2008 at 03:46:28PM +0200, Bernhard Walle wrote: > This patch series fixes the crashkernel reservation on NUMA machine. The > regression was discovered by Dave Anderson <anderson at redhat.com>. > > The background is that on NUMA machines, reserve_bootmem_generic() is required > instead of reserve_bootmem(). To achieve that, it's necessary to make a few > API changes. > > The patches are against latest linux-2.6 git. They should still go into 2.6.26 > since it's only bug fixing. For 2.6.27, we should unify crashkernel reservation > for i386 and x86-64. > > Tested on both i386 and x86-64. Compilation was tested with both kexec disabled > and enabled. The change is x86 only, so no need to test on other architectures. > > > Signed-off-by: Bernhard Walle <bwalle at suse.de> Yes we should be using reserve_bootmem_generic() for reserving memory on NUMA machines. Recently myself and Dave A. ran into crash while reserving memory using resreve_bootmem() on a NUMA machine. Reason for crash? reserve_bootmem() always assumes node id to be zero, and that was not the case. Acked-by: Vivek Goyal <vgoyal at redhat.com> Thanks Vivek
