[Patch] kexec: remove redundant if-else

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



WANG Cong <xiyou.wangcong at gmail.com> writes:

> These if-else's can be removed.

Why?  That appears to be pointless code style thrashing.

Converting code with a single return into code with multiple returns.
Which arguably makes it harder to prove properties about.

Further if you want to use the style you suggest a label name like err
is better than the name out.

But in this case where we have multiple results I don't like the proposed
change in style at all.  Especially with no rational.

Eric



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux