Thanks for the review comments. I will change to 'snprintf' at all the places and remove the unnecessary casts. On Tuesday 08 July 2008 07:06:46 Stephen Rothwell wrote: > Hi Chandru, > > On Tue, 8 Jul 2008 00:14:24 +0530 Chandru <chandru at in.ibm.com> wrote: > > + if (usm != NULL) { > > + ranges = (len >> 2) / (n_mem_addr_cells + > > ^^^^^^^^^^ > len / sizeof(u32) ? ranges is made to count the number of linux,usable-memory properties in the device tree. It's acting as a counter here. So the expression in the patch is fine. Thanks, Chandru