* Simon Horman <horms at verge.net.au> [2008-02-22 10:02]:
> On Thu, Feb 21, 2008 at 10:28:33AM +0100, Bernhard Walle wrote:
> > * Simon Horman <horms at verge.net.au> [2008-02-21 10:21]:
> > > On Wed, Feb 20, 2008 at 09:07:55AM +0100, Bernhard Walle wrote:
> > > > This patch fixes following compilation warning:
> > > >
> > > > purgatory/purgatory.c:21: warning: passing argument 2 of 'sha256_update' makes pointer from integer without a cast
> > > >
> > >
> > > Thanks Bernhard, I have queued that up.
> > > Although I notice that on arm the warning turns into
> > >
> > > purgatory/purgatory.c: In function 'verify_sha256_digest':
> > > purgatory/purgatory.c:21: warning: cast to pointer from integer of different size
> >
> > Isn't this the case on every 32 bit system?
>
> Yes, now you mention it, I expect so. I guess its not a problem.
But you didn't merge the patch. ;) Here's a version that should not
give any warnings ...
----------------------------
This patch fixes following compilation warning:
purgatory/purgatory.c:21: warning: passing argument 2 of 'sha256_update' makes pointer from integer without a cast
Signed-off-by: Bernhard Walle <bwalle at suse.de>
---
purgatory/purgatory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/purgatory/purgatory.c
+++ b/purgatory/purgatory.c
@@ -18,7 +18,7 @@ void verify_sha256_digest(void)
sha256_starts(&ctx);
end = &sha256_regions[sizeof(sha256_regions)/sizeof(sha256_regions[0])];
for(ptr = sha256_regions; ptr < end; ptr++) {
- sha256_update(&ctx, ptr->start, ptr->len);
+ sha256_update(&ctx, (uint8_t *)((uintptr_t)ptr->start), ptr->len);
}
sha256_finish(&ctx, digest);
if (memcmp(digest, sha256_digest, sizeof(digest)) != 0) {
