* Oleg Verych <olecom at flower.upol.cz> [2007-09-23 01:14]: > * Thu, 20 Sep 2007 19:18:46 +0200 > > [] > > extern u32 vmcoreinfo_note[VMCOREINFO_NOTE_SIZE/4]; > > extern unsigned int vmcoreinfo_size; > > extern unsigned int vmcoreinfo_max_size; > > +int __init parse_crashkernel(char *cmdline, unsigned long long system_ram, > > + unsigned long long *crash_size, unsigned long long *crash_base); > > (BTW, why `system_ram' is `unsigned long' in parse_crashkernel_mem() but > `unsigned long long' in parse_crashkernel()?) Because that's a bug, thanks for spotting that out. I will sent an updated version of this patch until the issue below has been clarified: > What is the point of not using `ulong' and `u64'? > > What about another names? > > +int __init get_crashkernel_params(u64 *memsize, u64 *addrbase, char *cmdline, u64 ram); Andrew, what's your opinion on this? Whould I resend the patch with shorter type names? Thanks, Bernhard
