Randy Dunlap wrote: > On Thu, 18 Oct 2007 17:53:00 +0900 Takenori Nagano wrote: > >> This patch adds new notifier function tunable_notifier_chain. Its base is >> atomic_notifier_chain. >> >> Thanks, >> >> --- >> >> Signed-off-by: Takenori Nagano <t-nagano at ah.jp.nec.com> >> >> --- >> diff -uprN linux-2.6.23.orig/kernel/sys.c linux-2.6.23/kernel/sys.c >> --- linux-2.6.23.orig/kernel/sys.c 2007-10-10 05:31:38.000000000 +0900 >> +++ linux-2.6.23/kernel/sys.c 2007-10-18 10:08:52.728000000 +0900 >> @@ -38,6 +38,7 @@ >> #include <linux/syscalls.h> >> #include <linux/kprobes.h> >> #include <linux/user_namespace.h> >> +#include <linux/debugfs.h> >> >> #include <asm/uaccess.h> >> #include <asm/io.h> >> @@ -393,6 +394,243 @@ int blocking_notifier_call_chain(struct >> EXPORT_SYMBOL_GPL(blocking_notifier_call_chain); > >> +/** >> + * tunable_atomic_notifier_chain_register >> + * - Add notifier to an tunable notifier chain > > Function name & short description must be on one (long?) line. :( OK. I'll fix next version. >> + >> +int __kprobes __tunable_atomic_notifier_call_chain( >> + struct tunable_atomic_notifier_head *nh, >> + unsigned long val, void *v, >> + int nr_to_call, int *nr_calls) >> +{ >> + int ret; >> + >> + rcu_read_lock(); >> + ret = notifier_call_chain(&nh->head, val, v, nr_to_call, nr_calls); >> + rcu_read_unlock(); >> + return ret; >> +} >> + >> +EXPORT_SYMBOL_GPL(__tunable_atomic_notifier_call_chain); > > Blank line is usually omitted before EXPORT_SYMBOL.... OK. I'll fix, too. Thanks, Takenori > --- > ~Randy > >