Vivek Goyal wrote: > On Thu, Oct 04, 2007 at 08:38:50PM +0900, Takenori Nagano wrote: > >> @@ -522,8 +530,8 @@ setup_arch(char **cmdline_p) >> } >> >> /* Register a call for panic conditions. */ >> - atomic_notifier_chain_register(&panic_notifier_list, >> - &alpha_panic_block); >> + tunable_notifier_chain_register(&panic_notifier_list, >> + &alpha_panic_block, "alpha_panic", NULL); >> > > I think it might be good idea to somehow create provisions for another a > help string. This help string will inform admin that what a registered > user does? Ideally this should be visible in /sys/kernel/debug/<user module>/description file. Hi Vivek, We can make description file with tunable_notifier_chain_register 4th argument. If developer sets 4th argument, tunable_notifier_chain_register makes /sys/kernel/debug/<name>/description file. Admin can get information from the description file. +/** + * tunable_notifier_chain_register - Add notifier to an tunable notifier chain + * @nh: Pointer to head of the tunable notifier chain + * @n: New entry in notifier chain + * @name: Pointer to the name of the new notifier entry + * @desc: Pointer to the description of new entry + * + * Adds a notifier to an tunable notifier chain and makes control dir. + * + * Returns zero on success or %-ENODEV on failure. + */ Thanks, Takenori Nagano <t-nagano at ah.jp.nec.com>
