Hi Simon, Thank you for reviewing and your "Acked-by" signs. Simon Horman wrote: > On Fri, Nov 16, 2007 at 11:33:20AM +0900, Ken'ichi Ohmichi wrote: >> This patch fixes the configuration dependencies in the vmcoreinfo data. >> >> i386's "node_data" is defined in arch/x86/mm/discontig_32.c, >> and x86_64's one is defined in arch/x86/mm/numa_64.c. >> They depend on CONFIG_NUMA: >> arch/x86/mm/Makefile_32:7 >> obj-$(CONFIG_NUMA) += discontig_32.o >> arch/x86/mm/Makefile_64:7 >> obj-$(CONFIG_NUMA) += numa_64.o >> >> ia64's "pgdat_list" is defined in arch/ia64/mm/discontig.c, >> and it depends on CONFIG_DISCONTIGMEM and CONFIG_SPARSEMEM: >> arch/ia64/mm/Makefile:9-10 >> obj-$(CONFIG_DISCONTIGMEM) += discontig.o >> obj-$(CONFIG_SPARSEMEM) += discontig.o >> >> ia64's "node_memblk" is defined in arch/ia64/mm/numa.c, >> and it depends on CONFIG_NUMA: >> arch/ia64/mm/Makefile:8 >> obj-$(CONFIG_NUMA) += numa.o >> >> Signed-off-by: Ken'ichi Ohmichi <oomichi at mxs.nes.nec.co.jp> > > This appears correct to me, checking through the symbols and the > location of their deffinitions, though I have not had a chance to run > many build checks. > > I also note that CONFIG_ARCH_DISCONTIGMEM_ENABLE does not even > appear to exist on i386, so it looks that without this change > the code in question whould never be enabled. If you enable "Numa Memory Allocation and Scheduler Support" in i386's menuconfig, CONFIG_ARCH_DISCONTIGMEM_ENABLE is enabled. Thanks Ken'ichi Ohmichi
