Vivek Goyal wrote: > On Mon, May 07, 2007 at 05:02:47PM -0700, Geoff Levand wrote: >> +#define dprintf(args...) dfprintf(stdout, args) >> #ifdef DEBUG >> -#define dfprintf(args...) do {fprintf(args);} while(0) >> +#define dfprintf(_f, _args...) do {fprintf(_f, _args);} while(0) > > Should't dprintf() also be inside #ifdef DEBUG? Then you need two identical defs for dprintf. -Geoff