On Sat, Jun 02, 2007 at 12:21:38AM +0200, francesco chiechi wrote: > Hello, > > We developed a patch to port kexec-tools to mips arch and included > support for command line passing through elf boot notes. We did it > for a customer of ours on a specific platform derived from toshiba > tx4938 (so we think it should work at least for tx4938 evaluation > board also). We would like to contribute it in case somebody else > needs it or wants to improve it. This patch works for us but the > assembler part in particular, should be considered as a starting point > because my assembly knowledge is not too deep. > > As this is the first time I submit a patch I tried to guess reading > tpp.txt if this is the right way to submit. Please let me know about > any mistakes I may have made. Hi Francesco, thanks for the patch. Sending them to this list is indeed the right thing to do. You can also CC me (who makes the commits) to be sure to get my attention. I'm curious to about all the #ifdef __MIPSEL__ stuff in kexec.c. Is there no chance that couldn't be placed somewhere in /kexec/arch/mipsel somehow? kexec is a bit hapazard in parts, but generally there isn't much #ifdef ARCH foo in there and we try and keep architecture-specific and generic code separated. Two other minor things: * please patch configure.ac, not configure * please provide a signed-off-by line, which is described at http://linux.yyz.us/patch-format.html amongst other places. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/
