On Thu, Dec 13, 2007 at 10:32:22AM -0500, Neil Horman wrote: > On Thu, Dec 13, 2007 at 04:16:29PM +0100, Andi Kleen wrote: > > On Thu, Dec 13, 2007 at 09:39:22AM -0500, Neil Horman wrote: > > > > > > Ok, new patch attached, taking into account Andi's request for a cleaner method > > > > Sorry for not noticing that earlier, but was there a specific reason this needs > > to be an early quirk at all? kexec can only happen after the standard quirks ran. > > I think it should be fine as a standard "late" quirk. > > > > -Andi > > > Early quirk seemed like the right thing to do to me. Starting from boot up, > this (mis)configuration by the bios can mean that come cpus just don't get > interrupts. I could imagine situations like serial console not working if the > serial port interrupt was routed to a cpu that used extended APIC id. I've > never actually observed it happening, but making sure that all cpus were > eligible to get interrupts early in the boot process made sense to me. > > Neil > Sorry to push on this, but do we have a consensus on this fix? Andi, do you still feel this needs to be a late quirk given my previous arguments? Regards Neil