Hi Bernhard, 2007/08/17 11:44:07 +0200, Bernhard Walle <bwalle at suse.de> wrote: >Hi, > >* Ken'ichi Ohmichi <oomichi at mxs.nes.nec.co.jp> [2007-08-17 08:43]: >> >> Thank you for good comments. >> I updated the patch for applying your comments. > >Instead of providing empty implementations of arch_save_vmcoreinfo() >for each architecture that doesn't need that hook, I'd suggest to use >one default implementation with __attribute((weak)) that gets >overwritten by architecture implementations. See my patch below: Thank you for a good patch. I'll update the patch based on yours. Thanks Ken'ichi Ohmichi