* Dan Aloni <da-x at monatomic.org> [2007-08-13 19:38]: > On Mon, Aug 13, 2007 at 04:36:53PM +0900, Ken'ichi Ohmichi wrote: > >[..] > > Patches: > > - [1/3] patch for linux-2.6.22. > > Changelog: > > * Rename "mkdfinfo" to "vmcoreinfo". > > * Multi memory models (FLATMEM, DISCONTIGMEM, and SPASEMEM) are > > supported. > > * The elf note typedef for vmcoreinfo is added because the original > > elf note size is limited to 1024. > > * The generation of the elf note is moved to boot time instead of > > crash time. > > This looks very good. Just one suggestion - in order to reduce clutter > from kernel/kexec.c (as to avoid #ifdefs) perhaps it might be better > to have crash_save_vmcoreinfo_init() additionally call an arch-specific > arch_crash_save_vmcoreinfo_init() function and have that append all > the arch-specific stuff. Because the only architecture that is really different is IA64, it may make sense here to provide a default implementation that is used on any architecture and declared as __attribute__((weak)). Then, any architecture (here: IA64) can override that implementation. That would avoid code duplication. The rest looks good from my point of view. I'd like to see that in the mainline kernel. :) Thanks, Bernhard
