On Wed, Jun 8, 2011 at 3:41 PM, Alexey Fisher <bug-track@xxxxxxxxxxxxxxxxx> wrote: > Hallo, > > i have small regression after patch: > commit 1c5cae815d19ffe02bdfda1260949ef2b1806171 > Author: Jiri Pirko <jpirko@xxxxxxxxxx> > Date: Â Sat Apr 30 01:21:32 2011 +0000 > > Â Ânet: call dev_alloc_name from register_netdevice > .... > > device names are broken. > Here is dmesg before patch: > [ 59.181464] wlan0: authenticate with 00:1c:10:xx:xx:xx (try 1) > [ 59.185954] wlan0: authenticated > [ 59.186027] wlan0: associate with 00:1c:10:xx:xx:xx (try 1) > [ 59.188679] wlan0: RX AssocResp from 00:1c:10:xx:xx:xx (capab=0x11 > status=0 aid=2) > > And dmesg after patch: > [ 76.046587] wlan%d: authenticate with 00:1c:10:xx:xx:xx (try 1) > [ 76.048600] wlan%d: authenticated > [ 76.048647] wlan%d: associate with 00:1c:10:xx:xx:xx (try 1) > [ 76.051281] wlan%d: RX AssocResp from 00:1c:10:xx:xx:xx (capab=0x11 > status=0 aid=2) > [ 76.051288] wlan%d: associated It is already fixed in wireless-testing commit 59e7e7078d6c2c6294caf454c6e3695f9d3e46a2 Author: Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxxxxxx> Date: Thu Jun 2 17:28:37 2011 -0300 mac80211: call dev_alloc_name before copying name to sdata This partially reverts 1c5cae815d19ffe02bdfda1260949ef2b1806171, because the netdev name is copied into sdata->name, which is used for debugging messages, for example. Otherwise, we get messages like this: wlan%d: authenticated Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxxxxxx> Cc: Jiri Pirko <jpirko@xxxxxxxxxx> Cc: David S. Miller <davem@xxxxxxxxxxxxx> Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> Cc: "John W. Linville" <linville@xxxxxxxxxxxxx> Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx> Thanks for reporting it! -- To unsubscribe from this list: send the line "unsubscribe kernel-testers" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html