On Tuesday 29 December 2009, OGAWA Hirofumi wrote: > "Rafael J. Wysocki" <rjw@xxxxxxx> writes: > > > This message has been generated automatically as a part of a report > > of regressions introduced between 2.6.31 and 2.6.32. > > > > The following bug entry is on the current list of known regressions > > introduced between 2.6.31 and 2.6.32. Please verify if it still should > > be listed and let me know (either way). > > > > > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14730 > > Subject : sky2 won't work after suspend/resume cycle > > Submitter : Maciej J. Woloszyk <mat@xxxxxxxxxx> > > Date : 2009-12-04 09:02 (26 days old) > > This seems to be related to commit 4b77b0a2ba27d64f58f16d8d4d48d8319dda36ff. > > It clears dev->state_saved blindly, but pci_pm_resume() calls > pci_restore_standard_config() before pm->resume() (by probably > historical reason). The other way around. pci_restore_standard_config() is the new thing and the pci_restore_state() in ->resume() is supposed to be unnecessary. Unfortunately in this case the restoration of PCI config registers in pci_restore_standard_config() doesn't work. I'd like to understand the reason, but temporarily we can just set pdev->state_saved to 1 in sky2_resume(), as proposed in the bug entry. > So, I guess it became the cause of restore regression before changing > PCI power state. It might be better to revert > 4b77b0a2ba27d64f58f16d8d4d48d8319dda36ff for now, until changing pci > generic stuff. In fact 4b77b0a2ba27 is a bug fix so I'm afraid it won't be safe to revert it. Rafael -- To unsubscribe from this list: send the line "unsubscribe kernel-testers" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
