On Mon, 27 Jul 2009, Christoph Lameter wrote: > My prosal was to use the size and objsize parameters. You would only have > to call calculate_sizes() twice when the comparison of the order of size > and objsize would be different. > > Doing so would simplify additing future flags. If you do your own > calculations (like in the patch) then you have to replicate the size > calculation from calculate_sizes() somehow. Is the duplicate calculation > really accurate regarding alignment and other special casing? > Ok, fair enough. It seems like a matter of taste in implementation but your proposal is also more extendable than mine, and I'm definitely not going to argue your taste vs. mine when it comes to slub :) I'll write an incremental patch on top of Pekka's for-next branch to implement your idea. -- To unsubscribe from this list: send the line "unsubscribe kernel-testers" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
