On Tue, Aug 26, 2008 at 1:14 PM, Kok, Auke <auke-jan.h.kok@xxxxxxxxx> wrote: > Linus Torvalds wrote: >> >> On Tue, 26 Aug 2008, Jeff Garzik wrote: >>> e1000_check_options builds a struct (singular) on the stack, really... struct >>> e1000_option is reasonably small. >> >> No it doesn't. >> >> Look a bit more closely. >> >> It builds a struct (singular) MANY MANY times. It also then builds up a >> huge e1000_opt_list[] array, even though it is const and should be static >> (and const). >> >> I know. I wrote a patch to FIX it. > > totally cool patch afaics - if I still maintained this driver I'd have this tested > and merged right away :) > > I suppose Jeff Kirsher is already doing so right now You suppose correctly. . > > I suppose that he'll have to look at the other Intel ethernet drivers as well :) > > Jeff, please add my: > > Reveiewed-by: Auke Kok <auke-jan.h.kok@xxxxxxxxx> > Will do. -- Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe kernel-testers" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
